Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rtn-web-browser): prevent CustomTab to show in recent used app #13847

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

AnantTiwari001
Copy link
Contributor

Description of changes

Add extra flag to the custom browser Tab to exclude the app from recently used apps.

Issue #13846

Description of how you validated changes

Went through the android documentation and tested it locally on various devices.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF changed the title prevent CustomTab to show in recent used app. fix(rtn-web-browser): prevent CustomTab to show in recent used app. Sep 24, 2024
@HuiSF HuiSF changed the title fix(rtn-web-browser): prevent CustomTab to show in recent used app. fix(rtn-web-browser): prevent CustomTab to show in recent used app Sep 24, 2024
@cwomack cwomack added Auth Related to Auth components/category React Native React Native related issue feature-request Request a new feature labels Sep 24, 2024
Copy link
Member

@cshfang cshfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Will add approval but could we verify that this doesn't have unintended consequences (like hiding the host app from recent?) as well?

@AnantTiwari001
Copy link
Contributor Author

@cshfang Yeah I do understand the risk of unintended effects.
Altho I do have tested it manually in both emulator and physical devices. And the Flag has been added specifically to the custom tab intent which won't leak, to other intents. Perhaps here is the link for documentation of flag in question.

Copy link
Member

@HuiSF HuiSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@HuiSF HuiSF merged commit c586b7b into aws-amplify:main Sep 27, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auth Related to Auth components/category feature-request Request a new feature React Native React Native related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants